fix(conf) retain IPv6 brackets in proxy_listen and admin_listen #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
requested changes
Jun 4, 2018
kong/conf_loader.lua
Outdated
| ip = utils.normalize_ip(remainder) | ||
| -- nginx requires brackets in IPv6 addresses, but normalize_ip does | ||
| -- not include them (due to backwards compatibility with its other uses) | ||
| if ip and ip.host:find(":", 1, true) then |
There was a problem hiding this comment.
For the sake reference code and efficiency, probably better to rely on:
if ip and ip.type == "ipv6" then
endnginx requires brackets in IPv6 addresses, but normalize_ip does not include them (due to backwards compatibility with its other uses) Fixes #3475.
hishamhm
force-pushed
the
fix/ipv6-listen-directives
branch
from
1515683 to
13a4e76
Compare
thibaultcha
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx requires brackets in IPv6 addresses, but
normalize_ipdoes not include them (due to backwards compatibility with its other uses elsewhere in the codebase).Fixes #3475.