fix(healthchecks) report timeouts on passive healthchecks #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE that this PR is currently on top of |
thibaultcha
force-pushed
the
feat/plugins-on-nginx-errors
branch
2 times, most recently
from
774d326 to
3dc04a3
Compare
Report both connection timeouts at the `balancer` phase and upstream timeouts as `timeout` events when using passive healthchecks. Previously, connection timeouts were being misreported as `tcp_failures`. Upstream timeouts can now be caught due to recent runloop improvements for executing plugins on Nginx-produced errors (#3533). Includes regression tests for both cases. From #3539
thibaultcha
force-pushed
the
fix/healthchecks-passive-timeouts
branch
from
dd622ef to
26cefaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report both connection timeouts at the
balancerphase andupstream timeouts as
timeoutevents when using passive healthchecks.Previously, connection timeouts were being misreported as
tcp_failures.Upstream timeouts can now be caught due to recent runloop improvements for
executing plugins on Nginx-produced errors (#3533).
Includes regression tests for both cases.