fix(schema) catch properly when foreign keys are null #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
reviewed
Jun 15, 2018
kong/db/schema/init.lua
Outdated
| @@ -858,7 +859,7 @@ function Schema:validate_primary_key(pk, ignore_others) | |||
| pk_set[k] = true | |||
| local field = self.fields[k] | |||
| local v = pk[k] | |||
| if not v then | |||
| if v == nil or v == null then | |||
There was a problem hiding this comment.
The only concern I have with this, is that if we have say plugins in new model that can have null in consumer_id, route_id, service_id, api_id, does this prevent that? Just double checking.
There was a problem hiding this comment.
Likely, but I think we should address the concern when the issue arises, and refactor/add new attributes only then.
hishamhm
force-pushed
the
fix/schema-missing-primary-key
branch
from
d0f51ea to
a805dc9
Compare
thibaultcha
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @fffonion for reporting it and to @bungle for the fix!
Includes both a general regression test for the schema library and a regression test specific for the Routes entity.