Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverless) bundle serverless function plugins #3551

Merged
merged 5 commits into from
Jun 19, 2018

Conversation

nijikokun
Copy link
Contributor

Bundles serverless function plugins into Kong CE.

Caveats

  • pre-function runs before zipkin, it is advisable to use post-function when using zipkin for accurate metric reporting.
    • If we want to change this behavior, I would advise that we raise the priority on the zipkin plugin to math.huge, and set the pre-function value close nearby to stay consistent with documentation.

@nijikokun
Copy link
Contributor Author

@thibaultcha that is correct, I have made a note of this in the PR description.

@thibaultcha
Copy link
Member

thibaultcha commented Jun 15, 2018

@nijikokun My comment was made on the commit and pre-dated the PR - hid it as "obsolete".

@coopr
Copy link
Contributor

coopr commented Jun 15, 2018

Is there any uncertainty as to "if we want to change this"? I can't guess why we would not want to change this - it seems necessary that Zipkin run before pre-function for the reason stated.

@nijikokun
Copy link
Contributor Author

@coopr that's what the purpose of that text is for, to decide such. I'm not sure whether it is necessary. There are two plugins (pre / post), one can run after Zipkin (post), one (pre) explicitly states it runs before all others.

Therefore, if you want to use a function and zipkin, you can use post.

@coopr
Copy link
Contributor

coopr commented Jun 15, 2018

Ah, thanks for the clarification.

In my opinion, if you are running Zipkin (or, really, anything else that monitors Kong's execution of Kong's code), you'd want it to start running as early as possible.

Running Zipkin before pre-function can't, as far as I understand, affect the execution of the pre-function in any way.

@thibaultcha thibaultcha merged commit b55844e into next Jun 19, 2018
@thibaultcha thibaultcha deleted the feat/add-serverless-functions branch June 19, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants