Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(constants) add new shms to required list & rename kong_cache #3557

Merged
merged 2 commits into from
Jun 19, 2018
Merged

chore(constants) add new shms to required list & rename kong_cache #3557

merged 2 commits into from
Jun 19, 2018

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Jun 18, 2018 •
edited
Loading

No description provided.

@thibaultcha
chore(constants) add new shms to required list
826b93b 
Render newly added shared dicts required. As 0.14 ships with breaking
changes and other nginx configuration changes, now is a good time to
render recent shared dicts mandatory.

See #3550
See #3311
bungle
bungle approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, this looks good to me.

@thibaultcha thibaultcha force-pushed the chore/add-required-shms branch from 690191a to 87726f0 Compare June 19, 2018 01:51
@thibaultcha thibaultcha merged commit b019b6b into next Jun 19, 2018
@thibaultcha thibaultcha deleted the chore/add-required-shms branch June 19, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaultcha @bungle