[feat/admin api] enable CORS support #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
feat/cors-api
branch
from
20f7da3 to
17ef3cb
Compare
|
Looks good as a first implementation. |
thibaultcha
added
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Jul 3, 2015
[feat/admin api] enable CORS support
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feat/admin api] enable CORS support Former-commit-id: 413d5b35a347df9784512bd57753d31b361646e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing CORS support in the Admin API #298.
This is the simplest way to do it, as I see no way to do it once Lapis has started processing the request.
Thoughts @ajayk @thefosk ?