fix(core) ensure a plugin created with PUT gets enabled #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a plugin is newly created with PUT (e.g. with
`/plugins/{uuid}`), this needs to trigger a regeneration
of the plugins map.
Our `dao:upsert` operation triggers an `"update"` CRUD event.
This change is the conservative approach to fixing the problem,
instead of changing the CRUD event and ensuring that all
consumers of CRUD events handle a new `"upsert"` event.
Includes a regression test.
Fixes #4191.
hishamhm
force-pushed
the
fix/plugin-put
branch
from
0098876 to
a23b054
Compare
thibaultcha
reviewed
Jan 18, 2019
| cache:invalidate("plugins_map:version") | ||
| end | ||
| log(DEBUG, "[events] Plugin updated, invalidating plugins map") | ||
| cache:invalidate("plugins_map:version") |
There was a problem hiding this comment.
A more efficient approach would be to be able to "query" the plugins_map to determine without the plugin in question is already part of it or not, and rebuild the map only when necessary. We can keep this as a backlog item for now.
thibaultcha
reviewed
Jan 18, 2019
| path = "/mypath", | ||
| }) | ||
| assert.res_status(401, res) | ||
| end) |
There was a problem hiding this comment.
I have a subsequent commit locally in which I moved this test to a more appropriate test suite (plugins_map invalidations have their own test suite).
|
Manually merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plugin is newly created with PUT (e.g. with
/plugins/{uuid}), this needs to trigger a regeneration of the plugins map.Our
dao:upsertoperation triggers an"update"CRUD event. This change is the conservative approach to fixing the problem, instead of changing the CRUD event and ensuring that all consumers of CRUD events handle a new"upsert"event.Includes a regression test.
Fixes #4191.