fix(db) ensure we reach schema consensus while bootstrapping #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bootstrapping, both `up` and `teardown` phases of each migration execute subsequently. If the `teardown` step executed DML statements, such statements can span all peers (due to replication factors). If the replica peers have not yet reached consensus for their schema, they will provoke errors and make the bootstrapping fail. This change ensures that we wait for schema consensus when: * before running `teardown` if `up` was just ran * after running `teardown` if `up` was _not_ just ran (see comment as for why) * after running all migrations that were to be run, if executing `run_up` only From another perspective: * `run_up == true`: wait for consensus at the very end (after executing all up steps) * `run_teardown == true`: wait for consensus after each teardown step * `run_up == true and run_teardown == true`: wait for consensus before each `teardown` step, and once at the very end (after all up and teardown steps) Fix #4229
Drop `post_run_up_migrations` and `post_run_teardown_migrations` in favor of a single `wait_for_schema_consensus`, since no distinction are really made between `up` and `teardown` post-steps of migrations anymore.
thibaultcha
force-pushed
the
fix/schema-consensus-before-teardown
branch
from
44c1d99 to
80bdc0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrapping, both
upandteardownphases of each migrationexecute subsequently. If the
teardownstep executed DML statements,such statements can span all peers (due to replication factors). If the
replica peers have not yet reached consensus for their schema, they will
provoke errors and make the bootstrapping fail.
This change ensures that we wait for schema consensus when:
teardownifupwas just ranteardownifupwas not just ran (see comment asfor why)
run_uponlyFrom another perspective:
run_up == true: wait for consensus at the very end (after executingall up steps)
run_teardown == true: wait for consensus after each teardown steprun_up == true and run_teardown == true: wait for consensus beforeeach
teardownstep, and once at the very end (after all up andteardown steps)
Fix #4229