[fix/mashape-analytics] ALF serializer and Buffer #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle an edgecase where `res` was being accessed while it was nil.
- fix an issue when `log_body` was true but the request had no body (GET request for example) - fix an issue when nginx is retrying against upstream after a timeout and resulting in multiple `upstream_response_time` values addressing #423
thibaultcha
added
the
pr/ready (but hold merge)
The refactor was initially due to the fact that the ALF Serializer couldn't have the `clientIPAddress` at the root level. Thus the plugin doesn't send one ALF with n entries but n ALFs instead. Fix an edge-case when some ALFs could be sent several times to the socket server. The only way to solve this is to have each buffer (one per API) sending itself its own data and be aware of what exactly has been received by the socket server already and what hasn't.
thibaultcha
force-pushed
the
fix/mashape-analytics
branch
from
6bb5068 to
97644ea
Compare
- buffer now watches its size (bytes) to avoid getting bigger than analytics's payload limit. - buffer is now responsible for sending its data - buffer will queue batches to be sent and those will never exceed the configured batch maximum size or socket maximum payload size
thibaultcha
force-pushed
the
fix/mashape-analytics
branch
from
97644ea to
ca68324
Compare
thibaultcha
changed the title
thibaultcha
added a commit
that referenced
this pull request
Jul 29, 2015
[fix/mashape-analytics] ALF serializer and Buffer
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[fix/mashape-analytics] ALF serializer and Buffer Former-commit-id: a73eb4470595441affa717f8207cc523a62a2b88
hutchic
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing various issues reported in #423
log_bodywas true but the request had no body (GETrequest for example)
and resulting in multiple
upstream_response_timevalues