[feature/config] remove port option for better usability #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
added
the
pr/ready (but hold merge)
|
KongDB won't work anymore? |
|
Ports are not removed, just specified another way. |
Since having the `port` option for Cassandra and also providing a way to set ports on a per-node basis, it makes it harder for users to "guess" how to add Cassandra nodes. This changes the config file to show that `hosts` is an array of `host:port` and can be intuitively modified. :warning: This is a breaking change since we don't support the `port` option anymore. Will need to be documented properly in `UPDATE.md` even if the steps are very straightforward.
thibaultcha
force-pushed
the
featutre/config/remove-port
branch
from
85237f4
to
e173cb8
Compare
thibaultcha
added a commit
that referenced
this pull request
Aug 10, 2015
[feature/config] remove port option for better usability
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature/config] remove port option for better usability Former-commit-id: c04914c4485e332beb50f562cd2ebbe60d008f68
hutchic
pushed a commit
that referenced
this pull request
Jun 10, 2022
…#457) * fix(useradd) make sure kong:kong exist and files ownership is correct If the group kong exists before installation, "useradd -U" would not create the kong user. The file ownership update would also fail. Firstly create the kong group; then create the kong user on demand. * fix(ownership) change the group to "root" Protect Kong files/directories. See Kong/kong-build-tools#457 (comment) * fix(package) tests for kong:kong -> kong:root * Revert "fix(ownership) change the group to "root"" This reverts commit b50c155b6bfea7a7e75f1fde4abc65af71ebbd07. * Revert "fix(package) tests for kong:kong -> kong:root" This reverts commit d66b848a68edd0e7f2a8f4b708bf5d0b1517375b. Co-authored-by: Isa Farnik <isa@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since having the
portoption for Cassandra and also providing a way to set ports on a per-node basis, it makes it harder for users to "guess" how to add Cassandra nodes.This changes the config file to show that
hostsis an array ofhost:portand can be intuitively modified.portoption anymore. Will need to be documented properly inUPDATE.mdeven if the steps are very straightforward.