[fix/key-auth] remove support for key in request body #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the issue recently raised about multipart requests crashing the key-auth plugin, we discussed internally that supporting the key in the request body did not really make sense anyways. It only works for requests with a body, and supporting querystring and headers already covers 100% of the use cases.
thibaultcha
added a commit
that referenced
this pull request
Sep 24, 2015
[fix/key-auth] remove support for key in request body
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the issue recently raised about multipart requests crashing the
key-auth plugin, we discussed internally that supporting the key in the
request body did not really make sense anyways. It only works for
requests with a body, and supporting querystring and headers already
covers 100% of the use cases.
See #565