hmac GH issues# 600 fix #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,7 +99,8 @@ local function load_secret(username) | |||
| local keys, err = dao.hmacauth_credentials:find_by_keys { username = username } | |||
| local result | |||
| if err then | |||
| return responses.send_HTTP_INTERNAL_SERVER_ERROR(err) | |||
| ngx_log(ngx.ERR, err) | |||
| return responses.send_HTTP_INTERNAL_SERVER_ERROR("Internal system error") | |||
There was a problem hiding this comment.
Here it is better to give the err. It will show the actual error in the logs for the user, but the consumer will only see a "Internal Server Error" body.
There was a problem hiding this comment.
Did not get you. Now i log the error instead of sending it as response body. Consumer does not need to know all details for internal failure.
There was a problem hiding this comment.
Like I said: don't log, it would log twice. I meant send_HTTP_INTERNAL_SERVER_ERROR logs for you, and override the error with "Internal Server Error", so replace your string by err.
There was a problem hiding this comment.
Got you, will revert back the change.
cleaning up reverting explicit logging
shashiranjan84
force-pushed
the
hmac-username-fix
branch
from
a0cdf58 to
dd4bfe7
Compare
shashiranjan84
added
the
pr/ready (but hold merge)
shashiranjan84
added a commit
that referenced
this pull request
Oct 12, 2015
hmac GH issues# 600 fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for #600. Now it will send 403 for wrong username instead of 500