Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for oauth2 plugin X-Forwarded-Proto HTTPS override #650

Merged
merged 1 commit into from
Oct 21, 2015

Conversation

CyExy
Copy link
Contributor

@CyExy CyExy commented Oct 21, 2015

We have an SSL wrapper and load balancer in front of kong so it would be unnecessary to wrap it just for kong.

"a de facto standard for identifying the originating protocol of an HTTP request, since a reverse proxy (load balancer) may communicate with a web server using HTTP even if the request to the reverse proxy is HTTPS ..."

source https://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Common_non-standard_request_fields

@CyExy
Copy link
Contributor Author

CyExy commented Oct 21, 2015

Not sure why the CI failed, runned make test-all locally and all of the test pass.

@subnetmarco
Copy link
Member

@CyExy Looks good to me. Can you submit the PR against the next branch?

Tests are failing because of a problem we currently have with our CI systems, but if it works locally it's good.

@CyExy
Copy link
Contributor Author

CyExy commented Oct 21, 2015

@thefosk hoped to sneak the fix in as a hot fix :) but if you would prefer to release it next I can rebase against next branch in a new PR.

@thibaultcha thibaultcha merged commit e070de8 into Kong:master Oct 21, 2015
@thibaultcha
Copy link
Member

Thanks! We are going to release a patch version for this and #644.

@CyExy
Copy link
Contributor Author

CyExy commented Oct 21, 2015

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants