hotfix(galileo) missing shared dict and skipped access phase fixes #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the access phase of the galileo handler is not executed, we are missing the ngx.ctx.analytics data in the ALF serializer. This fallsback on an empty ctx.
thibaultcha
added
pr/wip
4720b7b renamed the previous 'locks' shm and broke the galileo retry policy relying on it. To avoid users to modify their nginx config if they use a custom one, this makes galileo use the already present (and huge) 'cache' shm.
thibaultcha
force-pushed
the
hotfix/galileo
branch
from
c1b35cf to
c417407
Compare
thibaultcha
added a commit
that referenced
this pull request
Feb 3, 2016
hotfix(galileo) missing shared dict and skipped access phase fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing the ngx.ctx.analytics data in the ALF serializer. This fallsback
on an empty ctx.
policy relying on it. To avoid users to modify their nginx config if
they use a custom one, this makes galileo use the already present (and
huge) 'cache' shm.