New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL #106

Closed
dsadinoff opened this Issue May 24, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@dsadinoff

dsadinoff commented May 24, 2016

per https://github.com/KosherJava/zmanim/blob/master/src/net/sourceforge/zmanim/hebrewcalendar/JewishCalendar.java

The methods used to obtain the parsha were derived from the source code of HebCal by Danny Sadinoff and JCal for the Mac by Frank Yellin. Both based
their code on routines by Nachum Dershowitz and Edward M. Reingold. The class allows setting whether the parsha and
holiday scheme follows the Israel scheme or outside Israel scheme. The default is the outside Israel scheme.

I understand that KosherJava started out as GPL, but is now LGPL. Can you describe how that jibes with the GPL nature of the code used here?

@KosherJava

This comment has been minimized.

Show comment
Hide comment
@KosherJava

KosherJava May 24, 2016

Owner

@dsadinoff
I thank you for bringing this to my attention. I had years ago requested permission from Avrom Finkelstien when I moved this from a GPL to LGPL not realizing that the code he used was under the GPL. I would like your permission to continue releasing this under the LGPL. If that is not possible I will separate this portion of the code out of the main library, and allow a separate GPL package for the parsha functionality.
Thanks

Owner

KosherJava commented May 24, 2016

@dsadinoff
I thank you for bringing this to my attention. I had years ago requested permission from Avrom Finkelstien when I moved this from a GPL to LGPL not realizing that the code he used was under the GPL. I would like your permission to continue releasing this under the LGPL. If that is not possible I will separate this portion of the code out of the main library, and allow a separate GPL package for the parsha functionality.
Thanks

@dsadinoff

This comment has been minimized.

Show comment
Hide comment
@dsadinoff

dsadinoff May 24, 2016

Due to the history of the hebcal codebase, re-licensing is not an option without permissions from Dershowitz, Reingold, Stallman and perhaps the GNU Foundation, so I wouldn't count on it, sorry.

dsadinoff commented May 24, 2016

Due to the history of the hebcal codebase, re-licensing is not an option without permissions from Dershowitz, Reingold, Stallman and perhaps the GNU Foundation, so I wouldn't count on it, sorry.

@KosherJava

This comment has been minimized.

Show comment
Hide comment
@KosherJava

KosherJava May 24, 2016

Owner

@dsadinoff
Understood. It will take some time (probably a week) until I get to to separating it.
I would like to take the time to thank you for your pioneer work in open sourcing work so useful for Jews around the world. I don't think the landscape of open source Jewish software would be where it is today if not for your work.

Owner

KosherJava commented May 24, 2016

@dsadinoff
Understood. It will take some time (probably a week) until I get to to separating it.
I would like to take the time to thank you for your pioneer work in open sourcing work so useful for Jews around the world. I don't think the landscape of open source Jewish software would be where it is today if not for your work.

@dsadinoff

This comment has been minimized.

Show comment
Hide comment
@dsadinoff

dsadinoff May 24, 2016

My pleasure. Cheers!

dsadinoff commented May 24, 2016

My pleasure. Cheers!

@dsadinoff dsadinoff referenced this issue May 24, 2016

Closed

GPL #8

@KosherJava

This comment has been minimized.

Show comment
Hide comment
@KosherJava

KosherJava Aug 23, 2016

Owner

@dsadinoff,
It took much longer than anticipated to get this done. You can see the results in commit 750f7d6.
Thank you for your patience.

Owner

KosherJava commented Aug 23, 2016

@dsadinoff,
It took much longer than anticipated to get this done. You can see the results in commit 750f7d6.
Thank you for your patience.

@KosherJava KosherJava closed this Aug 23, 2016

@dsadinoff

This comment has been minimized.

Show comment
Hide comment
@dsadinoff

dsadinoff Aug 25, 2016

Roger that. Thanks.

dsadinoff commented Aug 25, 2016

Roger that. Thanks.

KosherJava added a commit that referenced this issue Sep 26, 2017

Remove references to Parsha code
The Parsha code was removed a while ago (see bug #106) pending a new LGPL implementation (or as a standalone GPL module). This removes the non-compilable formatting code that referenced the parsha code. Thank you @BehindTheMath for bringing this to my attention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment