Skip to content

adding from_map_to_data_row function #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

adding from_map_to_data_row function #1433

merged 2 commits into from
Sep 11, 2025

Conversation

CarloMariaProietti
Copy link
Contributor

Solving issue #719

Jolanrensen
Jolanrensen reviewed Sep 8, 2025
View reviewed changes
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/typeConversions.kt Outdated

public fun AnyRow.toMap(): Map<String, Any?> = df().columns().associate { it.name() to it[index] }

public fun Map<String, Any?>.toDataRow() : DataRow<*> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not well linted, run ktLintFormat for automatic linting before committing :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing, i have run ktLintFormat. Am I ready to open a new pull request? I'll try to write tests as soon as i can.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to open a new pull request :) just push to the current branch

@Jolanrensen Jolanrensen added this to the 1.0.0-Beta4 milestone Sep 8, 2025
@Jolanrensen
Copy link
Collaborator

Could you add a test for it? Maybe in org.jetbrains.kotlinx.dataframe.testSets.person.DataRowTests, that may be a good place. The implementation itself looks good :)

@CarloMariaProietti
Copy link
Contributor Author

I pushed a commit where i add test and fix the linting

@Jolanrensen
Copy link
Collaborator

Jolanrensen commented Sep 9, 2025 •
edited
Loading

All looks well, the CI also passes. Thanks! Feel free to merge (are you allowed to do that btw? I'm not sure actually, otherwise I'll hit the button :) )

It will likely be part of Beta4 :)

@CarloMariaProietti
Copy link
Contributor Author

Thank you! I am not allowed to merge, it would be great if you could do it.

@Jolanrensen Jolanrensen merged commit eda4e6e into Kotlin:master Sep 11, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolanrensen Jolanrensen Jolanrensen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-Beta4
Development

Successfully merging this pull request may close these issues.
2 participants
@CarloMariaProietti @Jolanrensen