Cum sum fixes #1467
Merged
Cum sum fixes #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
added
bug
zaleslaw
reviewed
Oct 1, 2025
| * `cumSum` only works on columns that contain solely primitive numbers. | ||
| * | ||
| * @param [skipNA\] Whether to skip null and NaN values (default: `true`). | ||
| * Similar to [sum][sum], [Byte][Byte]- and [Short][Short]-columns are converted to [Int][Int]. |
There was a problem hiding this comment.
Yep, unfortunately, there are KDoc rendering issues if you don't alias the types here
zaleslaw
reviewed
Oct 1, 2025
| * {@set [CumSumDocs.CUMSUM_PARAM]} | ||
| */ | ||
| @Refine | ||
| @Interpretable("GroupByCumSum0") |
There was a problem hiding this comment.
If we are marking the functions for Compiler Plugin, should we add a test for this trivial case?
@koperagen
There was a problem hiding this comment.
testing what? and how?
There was a problem hiding this comment.
No, usually i simply annotate functions and later adjust if anything is wrong (one time i forgot Refine annotation)
koperagen
requested changes
Oct 2, 2025
Jolanrensen
force-pushed
the
cumSum-fixes
branch
from
87a2998 to
8c5af58
Compare
Jolanrensen
force-pushed
the
cumSum-fixes
branch
from
48c9644 to
c8af8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some bug fixes and slight improvements required for #1061.
Also expanded kdoc