Bugfix for NPE with fillNulls #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #136
The problem with the example was the following:
This makes sense from a programming standpoint: Essentially a column with null values is matched to a schema with a non-null column. However, since the intention is to fill in those nulls, it might be okay for us to assume that this is fine. I think it's reasonable to say that for any
fillNulls
- andfillNA
call, the values should be considered nullable in thewith
statement. This PR fixes that.So now: