Add static rendering for GitHub #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
added
documentation
Jolanrensen
reviewed
Nov 13, 2023
|
|
||
| fun StringBuilder.emitBody() = emitTag("tbody") { | ||
| val rowsCountToRender = minOf(rowsCount(), configuration.rowsLimit ?: Int.MAX_VALUE) | ||
| for (rowIndex in 0..<rowsCountToRender) { |
There was a problem hiding this comment.
wow first time I see ..< in action, cool
Jolanrensen
approved these changes
Nov 14, 2023
Fixes #476 Signed-off-by: Ilya Muradyan <ilya.muradyan@jetbrains.com>
Signed-off-by: Ilya Muradyan <ilya.muradyan@jetbrains.com>
ileasile
force-pushed
the
static-html
branch
from
045209e
to
1451fce
Compare
|
Thanks for the performance fixes :) |
Jolanrensen
approved these changes
Nov 16, 2023
|
I'll also cherry-pick it into 0.12.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476
I tried to make the code effective and clean enough. However, there might be problems with hierarchical dataframes. Please check if it's the case and adjust the code, it shouldn't be hard. Don't forget that you can't add any JavaScript though.
An example notebook rendered with the library from this PR is here: https://gist.github.com/ileasile/a0b52c0df65bb401078cd845387dd6f0