migrate Titanic.ipynb to Kandy #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have an idea to post code changes here, if they are not so large, because Github doesn't support good diffs for Notebooks |
|
Please run it with the latest master so that the tables render correctly for github :) |
Jolanrensen
requested changes
Jan 2, 2024
There was a problem hiding this comment.
I'll review like cell:line: comment :)
- 15:6: Probably replace with
JetBrainsColors.darkGreyright? - 19:1: Very long line, maybe split it across multiple
- 21:3: Also long, but better than the last one
- 31:: Hmm, the color of the small circles is very hard to see, could these be scaled up?
Like I said in the previous comment, please run the notebook from the master branch published to mavenLocal such that the tables render on GH :)
Other than that, very nice! Kandy is so much easier to read than Let's Plot haha
|
I'll merge this for now and check it for 0.13.1-RC1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437
I realized that there's no CorrPlot a bit too late, but found that corr + gather can prepare data for plotting very well too, yielding almost the same results. Also adjusted the look.