New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-format reports #35
Conversation
whyoleg
commented
Feb 20, 2021
•
edited
edited
- CSV/SCSV/TEXT JMH-similar formatter for JS/Native
- possibility to select format from gradle plugin
- fixes Support CSV result format #34
- printing summary after suite execution on all platforms
@qurbonzoda Hey, can you check, if the way it's implemented will fit current state of kx.benchmark? There is almost no tests for any of functionality, so what is the best way to test the implementation, only publish to maven-local and use it? Or may be you can suggest me something else? |
Implement JMH-similar JS/Native CSV/SCSV/TEXT formatters Print summary after suite execution on all platforms
d3ee086
to
cd545c2
Compare
runtime/jvmMain/src/kotlinx/benchmark/jvm/JvmBenchmarkRunner.kt
Outdated
Show resolved
Hide resolved
runtime/jvmMain/src/kotlinx/benchmark/jvm/JvmBenchmarkRunner.kt
Outdated
Show resolved
Hide resolved
Any news on PR review? |
There is
Currently the project doesn't have a more comprehensive testing infrastructure to test output of a benchmark with given configuration. |
I'm not sure about when that PR will be merged to master. Better to sit on master for now, maybe this PR will get merged first. |
|
runtime/commonMain/src/kotlinx/benchmark/BenchmarkReportFormatter.kt
Outdated
Show resolved
Hide resolved
runtime/commonMain/src/kotlinx/benchmark/BenchmarkReportFormatter.kt
Outdated
Show resolved
Hide resolved
Great job! |
take a look #37 :) |
first = false | ||
names.takeWhile { it.toLowerCase() == it } | ||
} else { | ||
val common = prefix.zip(names).takeWhile { (p, n) -> p == n && n.toLowerCase() == n } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: n.toLowerCase() == n
is redundant. If prefix
already meets p.toLowerCase() == p
, and p == n
, then n.toLowerCase() == n
is true
@qurbonzoda Looks like an awesome step forward. Would you mind putting out a new release for this? |
@OliverO2 We will publish a new release in the coming weeks with Kotlin 1.5. |
@OliverO2 A new release with multiple report formats is published. The Kotlin version remains 1.4.30 |
@qurbonzoda Excellent! Thanks for pinging. Will try. |
Can confirm that |