Native: make range for Instants and LocalDate a 1000 times narrower #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
approved these changes
Jul 22, 2020
ilya-g
reviewed
Jul 22, 2020
core/nativeMain/src/Util.kt
Outdated
| val sum = a + b | ||
| // check for a change of sign in the result when the inputs have the same sign | ||
| if ((a xor sum) < 0 && (a xor b) >= 0) { | ||
| throw ArithmeticException("Addition overflows a long: $a + $b") |
This is done to support `LocalDate.daysUntil(...): Int` always having a precise value. Additionally, it allows to simplify some parts of the implementation. Before, the Native implementation was using the same representable ranges as the Java implementation; now, it uses the same ranges as the JS implementation, which are narrower so that everything fits in a JS number.
dkhalanskyjb
force-pushed
the
native-smallerRange
branch
from
cb3c93a to
d8f09e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to support
LocalDate.daysUntil(...): Intalwayshaving a precise value. Additionally, it allows to simplify some
parts of the implementation.
Before, the Native implementation was using the same representable
ranges as the Java implementation; now, it uses the same ranges as
the JS implementation, which are narrower so that everything fits
in a JS number.