KRPC-162 Internal vs Public Codegen separation in gRPC #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
changed the title
e5l
approved these changes
Feb 14, 2025
protobuf-plugin/src/main/kotlin/kotlinx/rpc/protobuf/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
Mr3zee
added a commit
that referenced
this pull request
Feb 20, 2025
Mr3zee
added a commit
that referenced
this pull request
Apr 10, 2025
Mr3zee
added a commit
that referenced
this pull request
Apr 11, 2025
Mr3zee
added a commit
that referenced
this pull request
Apr 18, 2025
Mr3zee
added a commit
that referenced
this pull request
May 8, 2025
Mr3zee
added a commit
that referenced
this pull request
May 14, 2025
Mr3zee
added a commit
that referenced
this pull request
Jun 30, 2025
Mr3zee
added a commit
that referenced
this pull request
Jul 9, 2025
Mr3zee
added a commit
that referenced
this pull request
Jul 9, 2025
Mr3zee
added a commit
that referenced
this pull request
Jul 24, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 1, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 8, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC Protobuf plugin
Problem Description
Internal and public generated entities were placed into a single file, which complicates the comprehension of the content
Solution
Separate them into two files, placing internal declarations into the
_rpc_internalsubdirectory (but package is the same)