Skip to content

Conversation

Mr3zee
Copy link
Member

@Mr3zee Mr3zee commented Aug 19, 2025

Subsystem
Protobuf

Problem Description
Some tests were failing due to non conformance

Solution
Fixed:

  • Repeated size calculation
  • Default values
  • Messages size calculation
  • Packed/unpacked decoding
  • BytesUntilLimit check
  • repeated fields

@Mr3zee Mr3zee requested a review from Jozott00 August 19, 2025 10:35
@Mr3zee Mr3zee self-assigned this Aug 19, 2025
@Mr3zee Mr3zee added the bug Something isn't working label Aug 19, 2025
@Mr3zee Mr3zee force-pushed the protobuf-conformance-fixes branch from d56e60e to f3d5570 Compare August 19, 2025 12:06
Copy link
Collaborator

@Jozott00 Jozott00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice that almost all intended tests are passing now!

Just one concern/question regarding the checkRequiredFields() invocation place.

@Mr3zee Mr3zee merged commit d6e64d8 into grpc-common Aug 20, 2025
4 of 5 checks passed
@Mr3zee Mr3zee deleted the protobuf-conformance-fixes branch August 20, 2025 10:15
Mr3zee added a commit that referenced this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants