grpc: Fix service names in the generated descriptor #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozott00
force-pushed
the
grpc/fix-service-identifier
branch
from
51f1ed4 to
a610c49
Compare
Mr3zee
requested changes
Aug 20, 2025
...mpiler-plugin-backend/src/main/kotlin/kotlinx/rpc/codegen/extension/RpcDeclarationScanner.kt
Outdated
Show resolved
Hide resolved
...in/compiler-plugin-backend/src/main/kotlin/kotlinx/rpc/codegen/extension/RpcStubGenerator.kt
Outdated
Show resolved
Hide resolved
...in/compiler-plugin-backend/src/main/kotlin/kotlinx/rpc/codegen/extension/RpcStubGenerator.kt
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
…ackage` option for the service name. Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Jozott00
force-pushed
the
grpc/fix-service-identifier
branch
from
d6b38c0 to
45edf31
Compare
Mr3zee
reviewed
Aug 21, 2025
grpc/grpc-core/src/commonTest/kotlin/kotlinx/rpc/grpc/test/CoreClientTest.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Mr3zee
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC
Problem Description
Currently the generated gRPC service name in the descriptor is just the simple names of the Kotlin interface. However, in gRPC a service name is structured as
<proto-package>.<name>.Additionally, the stub generator had no information about the
proto-packageset in the proto file, which is required to generate the correct service name.Solution
This PR adds the
protoPackageargument to the@Grpcannotation. The service interface generator will set it if thepackageproperty is set in the proto file.This argument is then used by the service stub generator to obtain the proto package name.
To test this, the JavaPackageOptionTest was added, as well as an additional service interface in the compiler plugin tests.
Additionally, this PR moves the CoreClientTest into commonTest and provides service implementations that are required to run the tests. While it is not yet possible to automatically execute those tests, it got easier.