Skip to content

Conversation

Jozott00
Copy link
Collaborator

Subsystem
Protobuf

Problem Description
Groups were not supported or implemented, and they even caused a crash when the wire contained a GROUP tag.

Solution
The PR implements group support, which resulted in 10 more tests passing the conformance tests, specifically proto3 tests that validate the correct parsing error behavior for invalid END_GROUP tests.

However, functionality is also implemented for proto2 and editions that actually use groups in their proto file.

=== Conformance Test Results ===
Total baseline tests:   5545
[+] Passed tests:       1392
[-] Failed tests:       4153

@Mr3zee
Copy link
Member

Mr3zee commented Sep 10, 2025

@Jozott00 looks like auto-lint on commit was applied to some generated classes

@Jozott00 Jozott00 marked this pull request as ready for review September 10, 2025 12:59
@Jozott00 Jozott00 requested a review from Mr3zee September 10, 2025 13:01
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️⚡️⚡️

Do we enable proto2 tests and editions then?

@Jozott00
Copy link
Collaborator Author

Proto2, Proto2 Editions and Editions2023 conformance tests are activated in the next PR.
At the stage of this PR there are a couple of issues with the proto2 generated source code that leads to compile issues which are not related to groups.

@Jozott00 Jozott00 added the feature New feature or request label Sep 10, 2025
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
@Jozott00 Jozott00 merged commit 000b2fa into grpc-common Sep 10, 2025
5 of 6 checks passed
@Jozott00 Jozott00 self-assigned this Sep 10, 2025
@Jozott00 Jozott00 deleted the pb/groups branch September 11, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants