protobuf: Add support for deprecated groups #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Protobuf
Problem Description
Groups were not supported or implemented, and they even caused a crash when the wire contained a GROUP tag.
Solution
The PR implements group support, which resulted in 10 more tests passing the conformance tests, specifically proto3 tests that validate the correct parsing error behavior for invalid
END_GROUP
tests.However, functionality is also implemented for proto2 and editions that actually use groups in their proto file.