Skip to content

Conversation

dkhalanskyjb
Copy link
Collaborator

Fixes #3673

@dkhalanskyjb dkhalanskyjb requested a review from qwwdfsad March 13, 2023 13:19
@dkhalanskyjb dkhalanskyjb force-pushed the runTest-binary-compatible branch from 401b2d6 to ff78b25 Compare March 13, 2023 14:09
@qwwdfsad
Copy link
Member

Shouldn't it target develop?

@dkhalanskyjb dkhalanskyjb changed the base branch from master to develop March 13, 2023 14:17
@dkhalanskyjb
Copy link
Collaborator Author

It should.

@qwwdfsad
Copy link
Member

On the one hand, I'm delighted to know that kotlinx-coroutines-test provides enough value to be used in compose test utilities even in its experimental state. On the other hand, it's a bit terrifying as we have to care about backwards compatibility for experimental API even more

@dkhalanskyjb
Copy link
Collaborator Author

Yeah, I, too, was taken aback. I knew people depended on experimental functions, but I thought the experimental + tests would be the one area where production-like stability guarantees are unnecessary. Alas, we seem to be firmly in the https://xkcd.com/1172/ territory.

@dkhalanskyjb dkhalanskyjb merged commit 81baf9c into develop Mar 14, 2023
@dkhalanskyjb dkhalanskyjb deleted the runTest-binary-compatible branch March 14, 2023 11:16
@arkivanov
Copy link

Perhaps, a library shouldn't use any experimental API, to avoid this kind of problems? Unless the library itself is experimental.

@qwwdfsad
Copy link
Member

Depends on the library. It's okay to use it as long all available API depending on this API is also marked experimental.

For example, we had a stable delay(long) function and @ExperimentalStdlibApi delay(Duration) when duration was experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants