Fix description of samp and add strike tag #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinAman
commented
Jul 9, 2021
| @@ -53,7 +53,7 @@ fun humanizeJoin(parts: Iterable<String>, separator: String): String { | |||
| filteredParts.add(cutPart) | |||
| } | |||
|
|
|||
| return filteredParts.joinToString(separator = separator, transform = String::capitalize) + trailingParts.joinToString("", transform = String::capitalize) | |||
| return filteredParts.joinToString(separator = separator) { it.capitalize() } + trailingParts.joinToString("") { it.capitalize() } | |||
There was a problem hiding this comment.
This change was made since generation fails with exception:
* What went wrong:
Execution failed for task ':generate'.
> 'void kotlin.jvm.internal.FunctionReferenceImpl.<init>(int, java.lang.Class, java.lang.String, java.lang.String, int)'
|
strike is deprecated. Use s instead: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strike |
e5l
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Hey @MarcinAman, thanks for the PR.
Sorry for the long delay!
I've rebased the PR, fixed the tag name, and minor stuff.
LGTM
e5l
pushed a commit
that referenced
this pull request
Jan 12, 2024
Follow-up of Kotlin update in: - #184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.