Skip to content

fix: adapt to Kotlin 2.1.20 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: adapt to Kotlin 2.1.20 #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79de731
fix: adapt to Kotlin 2.1.20
DanySK Mar 24, 2025
b3dbd34
style: drop unused import
DanySK Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions npm-publish-gradle-plugin/src/main/kotlin/config/kotlinJsTarget.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import org.gradle.api.tasks.Copy
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinJsCompilation
import org.jetbrains.kotlin.gradle.targets.js.dsl.KotlinJsBinaryMode
import org.jetbrains.kotlin.gradle.targets.js.dsl.KotlinJsTargetDsl
import org.jetbrains.kotlin.gradle.targets.js.ir.Executable
import org.jetbrains.kotlin.gradle.targets.js.ir.JsIrBinary
import org.jetbrains.kotlin.gradle.targets.js.ir.KotlinJsIrTarget
import org.jetbrains.kotlin.gradle.targets.js.ir.Library
Expand All @@ -35,11 +34,13 @@ internal fun Project.configure(target: KotlinJsTargetDsl): Unit = with(PluginLog
extensions.getByType(NpmPublishExtension::class.java).packages.register(target.name) { pkg ->
val binary = provider<JsIrBinary> {
when (val it = target.binaries.find { it.mode == KotlinJsBinaryMode.PRODUCTION }) {
null -> null
is Library -> it
is Executable -> {
// Kotlin 2.1.20 introduces LibraryWasm and ExecutableWasm.
else -> {
warn {
"""
Kotlin/JS executable binaries are not valid npm package targets.
Kotlin/JS ${it::class.simpleName} binaries are not valid npm package targets.
Consider switching to Kotlin/JS library binary:
kotlin {
js(IR) {
Expand All @@ -50,8 +51,6 @@ internal fun Project.configure(target: KotlinJsTargetDsl): Unit = with(PluginLog
}
null
}

null -> null
}
}
val compileKotlinTask = binary.flatMap<Kotlin2JsCompile>(JsIrBinary::linkTask)
Expand Down