Fix middle height computation in 3D dynamics #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics (and usage) of the function is such that it returns 4 bytes: lower height, middle height, upper height, and 0xFF.
I believe the brackets "(" and ")" were accidentally put in the wrong place here for the middle term.
|
|
|
It is used only in |
|
@stalkerg wait, so if it's only used in DEBUG, it's fine to keep this bug? Why not land the fix? |
|
@kvark do we really use DEBUG? We have no formal way to test your change. |
|
If we don't use |
|
this code here for historical reason, I suppose we easily can remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics (and usage) of the function is such that it returns 4 bytes: lower height, middle height, upper height, and 0xFF. I believe the brackets "(" and ")" were accidentally put in the wrong place here for the middle term.