Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the NoneType error during initating the LCA object (#246) #247

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

chtsai0105
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).

@evanroyrees evanroyrees self-requested a review March 12, 2022 01:28
@evanroyrees evanroyrees linked an issue Mar 15, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 15, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c38bcd4

+| ✅  62 tests passed       |+
#| ❔  34 tests were ignored |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/autometa/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/autometa/main/nextflow_schema.json
  • schema_description - No description provided in schema for parameter: plaintext_email
  • schema_description - No description provided in schema for parameter: custom_config_version
  • schema_description - No description provided in schema for parameter: custom_config_base
  • schema_description - No description provided in schema for parameter: hostnames
  • schema_description - No description provided in schema for parameter: show_hidden_params
  • schema_description - No description provided in schema for parameter: singularity_pull_docker_container

❔ Tests ignored:

  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_exist - File is ignored: .github/workflows/branch.yml
  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/nf-core-autometa_logo_light.png
  • files_exist - File is ignored: docs/usage.md
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/images/nf-core-autometa_logo.png
  • files_exist - File is ignored: docs/images/nf-core-autometa_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-autometa_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/bug_report.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/feature_request.md
  • nextflow_config - nextflow_config
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File does not exist: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File does not exist: assets/nf-core-autometa_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-autometa_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-autometa_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or foo
  • actions_ci - '.github/workflows/ci.yml' not found
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/Autometa/Autometa/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2022-03-15 15:48:10

Copy link
Collaborator

@evanroyrees evanroyrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chtsai0105, I've updated the PR where we will not have any breaking changes for the cache. Thanks again for submitting! 🎉 🥳 🛠️

@evanroyrees evanroyrees added bug Something isn't working hotfix bug causing issues in main that should be resolved immediately labels Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #247 (c38bcd4) into main (ad0364a) will decrease coverage by 0.31%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   27.61%   27.30%   -0.32%     
==========================================
  Files          45       45              
  Lines        5334     5336       +2     
==========================================
- Hits         1473     1457      -16     
- Misses       3861     3879      +18     
Flag Coverage Δ
unittests 27.30% <25.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
autometa/taxonomy/lca.py 8.79% <25.00%> (-0.06%) ⬇️
autometa/binning/unclustered_recruitment.py 83.15% <0.00%> (-8.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0364a...c38bcd4. Read the comment docs.

@evanroyrees evanroyrees merged commit 3e581b9 into KwanLab:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hotfix bug causing issues in main that should be resolved immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autometa-taxonomy-lca return TypeError without specifying --cache
2 participants