Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling Threads and Retry for Web Chat #2232

Merged
merged 9 commits into from
Mar 26, 2023
Merged

Enabling Threads and Retry for Web Chat #2232

merged 9 commits into from
Mar 26, 2023

Conversation

yk
Copy link
Collaborator

@yk yk commented Mar 26, 2023

  • separates prompter and assistant messages
  • enables finding the current thread in the conversation tree in the web frontend
  • adds a retry button on failed messages

@AbdBarho
Copy link
Collaborator

separates prompter and assistant messages

I am curious as to which problem is solved by this?

@yk
Copy link
Collaborator Author

yk commented Mar 26, 2023

I am curious as to which problem is solved by this?

  • can re-try on error
  • can suggest to re-sample if the user votes thumbs-down
  • can sample multiple times and let the user compare

notmd
notmd approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. But I wonder why we have to do 2 request to just send and get a message. Why we don't stream the message immediately when user post a prompter message? But anyway, I'm fine with it.

website/src/components/Chat/ChatConversation.tsx Outdated Show resolved Hide resolved
website/src/components/Chat/ChatConversation.tsx Outdated Show resolved Hide resolved
Base automatically changed from send-message-read-with-error to main March 26, 2023 17:59
@yk yk requested a review from melvinebenezer as a code owner March 26, 2023 17:59
@yk yk enabled auto-merge (squash) March 26, 2023 18:35
@yk yk disabled auto-merge March 26, 2023 19:37
@andreaskoepf andreaskoepf merged commit 56ded48 into main Mar 26, 2023
@andreaskoepf andreaskoepf deleted the separate-prompter-from-assistant-message branch March 26, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmd notmd notmd approved these changes

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@olliestanley olliestanley Awaiting requested review from olliestanley olliestanley is a code owner

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

@melvinebenezer melvinebenezer Awaiting requested review from melvinebenezer melvinebenezer is a code owner

Assignees
No one assigned
Labels
inference website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yk @AbdBarho @andreaskoepf @notmd