Added admin dashboard link to UserMenu #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klotske
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
requested changes
Jan 11, 2023
| href: "/admin", | ||
| desc: "Admin Dashboard", | ||
| icon: FiShield, | ||
| }, |
There was a problem hiding this comment.
this will probably error on non-admin users.
can you move it out of the array and use push or unshift?
There was a problem hiding this comment.
Tested, was working without errors
Fixed in b568f12
fozziethebeat
approved these changes
Jan 11, 2023
|
Will let @AbdBarho merge after verifying this works |
AbdBarho
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added link to
/adminpage to theUserMenucomponent.Link is conditionally rendered depending on user role.