Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug Open-Assistant #67 : submit form on enter #69

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

seyfeddinenecib
Copy link
Contributor

Adding submit of the signup form when clicking "Enter"

@yk
Copy link
Collaborator

yk commented Dec 26, 2022

hey, thanks so much for contributing :)

is there an argument for / against just making this into a form and then handling the submit? it seems like that could be a bit more streamlined than explicitly checking enter.

@yk yk linked an issue Dec 26, 2022 that may be closed by this pull request
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Yannic, Rather than a new input, let's make this a proper form which should get us to the same place.

@yk
Copy link
Collaborator

yk commented Dec 26, 2022

for reference, you can probably just spy on #68 where I introduce another login form that uses a proper form

@seyfeddinenecib
Copy link
Contributor Author

I implemented the changes.

@fozziethebeat fozziethebeat merged commit 35f5770 into LAION-AI:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign up form should submit on enter key
3 participants