OfflineMode #243
OfflineMode #243
Conversation
# Conflicts: # app/src/main/java/com/lastaoutdoor/lasta/ui/screen/moreinfo/MoreInfoScreen.kt # app/src/main/java/com/lastaoutdoor/lasta/viewmodel/MoreInfoScreenViewModel.kt # app/src/test/java/com/lastaoutdoor/lasta/viewmodel/MoreInfoScreenViewModelTest.kt
There was a problem hiding this comment.
Good job ! The implementation is really clever and was much needed, thank you for spending time on it for the past weeks :) I added small comments on the else cases of your type transitions but they are not worth a change request, it's only something to take into account in case we change some naming conventions or add possibilities to some enums. Maybe a case switch would be better in this context
(Be careful in case you didn't notice the CI fails for the moment but I'm sure you are on it)
| fun toClimbingSyle(s: String): ClimbingStyle { | ||
| return if (s == "Outdoor") { | ||
| ClimbingStyle.OUTDOOR | ||
| } else { |
There was a problem hiding this comment.
Maybe be careful with this else if in the future we add a third climbing style or change the naming
| Difficulty.EASY | ||
| } else if (s == "Normal") { | ||
| Difficulty.NORMAL | ||
| } else { |
There was a problem hiding this comment.
Same remark for here, etc
|
Implemened an offlineMode for activities , allowing user to save activtities locally using the download button in the MoreInfo tab. Users can then see these activities in the favorites tab while offline