Add basic support for 16-bit color output (not tested) #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1993
commented
Jun 11, 2020
| struct GB_gameboy_s; | ||
| typedef struct GB_gameboy_s GB_gameboy_t; | ||
|
|
||
| #ifdef GB_16BIT_OUTPUT_COLOR |
There was a problem hiding this comment.
I'm not sure if gc_struct_def.h is a good location for this define, but it seems that it is only working option.
LIJI32
force-pushed
the
master
branch
4 times, most recently
from
4ebe973
to
0989ee2
Compare
|
Does this belong to upstream? Especially if it's not tested, and no front-end uses it... |
|
Honestly, I think I replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick thing I tried to do. As mentioned in the title, not tested. Please review this if you have time.
As for why, I'm currently trying to port SameBoy onto microcontroller and buffer of
uint32_tis a serious waste of memory, especially considering that actual color is 16-bit value anyways.I'm not familiar with internals of SameBoy, so I might have either missed something or changed something I shouldn't had.