Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added temporary fix for the EIP 1271 Issue #171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brieyla1
Copy link

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Introducing new feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Link to the relevant updated sections in the Netlify preview

  • Link 1: added notes on the authSig issue related to EIP-1271 (abstracted wallets)

Checklist:

General

  • I have performed a self-review of my code
  • I have fixed all grammar issues (can use an AI tool to check), and explanations are in active voice
  • I have checked the additions are concise
  • Language is consistent with existing documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published (ie. SDK changes, node dependencies)

If I have added a new concept, I have

  • included a beginner friendly explanation
  • included a basic technical introduction and code sample
  • new terms are defined, both in relevant new pages and in the glossary

Updated Docs for ERC 1271 that include the current issue with
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for lit-dev-docs ready!

Name Link
🔨 Latest commit 35bc697
🔍 Latest deploy log https://app.netlify.com/sites/lit-dev-docs/deploys/6556bdfbd72b93000701d8ee
😎 Deploy Preview https://deploy-preview-171--lit-dev-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kouraf
Copy link

kouraf commented Nov 17, 2023

A solution to fix this problem once and for all could be to receive the _hash to send to the contract directly and not manipulate it. Why isn't it done that way?
Additionally, I don't think you can afford to assume anything about the implementation of isValidSignature because its entire purpose lies in the fact that it can be implemented freely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants