Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves pnnl_cleanup to .pre stage and removes files based on age #555

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

jdmacam
Copy link
Collaborator

@jdmacam jdmacam commented Oct 4, 2022

Updates the pnnl_cleanup job in .gitlab-ci.yml to:

  • run during the .pre stage
  • remove files based on age (over 6 hours old) to cleanup ci account space

Comment on lines 193 to +194
pnnl_cleanup:
stage: test
dependencies:
- build_on_incline
stage: .pre
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cameronrutherford
Copy link
Collaborator

Since this is touching GitLab CI, could we also do some configuration of the git strategy for other pipelines?

I think we can disable cloning in the following:

  • test_on_lassen
  • test_on_quartz
  • test_on_compute_node
  • pnnl_cleanup

@nychiang for some reason the LLNL pipelines are also failing. I'm not as familiar with your CI setup (and don't have access), so feel free to clarify anything.

@cameronrutherford
Copy link
Collaborator

I don't know if this should just be addressed in a different PR, but it would also be good to re-factor to move away from YAML anchors, we well as separating each platform's CI pipelines into separate files for readability.

@jdmacam if you want to leave that for another PR, please create an issue to track the refactoring (along with viewing Ascent/Crusher pipeline status) and we can merge this sooner rather than later.

@nychiang
Copy link
Collaborator

nychiang commented Oct 4, 2022

@cameronrutherford I resubmit the pipeline and everything looks good to me. Probably our platform was too busy when you launched the pipeline.

@jdmacam
Copy link
Collaborator Author

jdmacam commented Oct 4, 2022

Since this is touching GitLab CI, could we also do some configuration of the git strategy for other pipelines?

I think we can disable cloning in the following:

  • test_on_lassen
  • test_on_quartz
  • test_on_compute_node
  • pnnl_cleanup

@cameronrutherford I've added the variable to those pipelines

Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and all pipelines pass. I think this can be merged.

You should notice tests passing a little bit faster as we will no longer have to clone the git repo before running tests where unecessary.

@cnpetra cnpetra merged commit 6b50f92 into develop Oct 5, 2022
@cnpetra cnpetra deleted the pnnl-ci-cleanup-fix branch September 11, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants