-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moves pnnl_cleanup to .pre stage and removes files based on age #555
Conversation
pnnl_cleanup: | ||
stage: test | ||
dependencies: | ||
- build_on_incline | ||
stage: .pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/questions/56324070/with-gitlab-ci-how-to-disable-repository-clone-for-one-job - let's remove the cloning step for this pipeline.
Since this is touching GitLab CI, could we also do some configuration of the git strategy for other pipelines? I think we can disable cloning in the following:
@nychiang for some reason the LLNL pipelines are also failing. I'm not as familiar with your CI setup (and don't have access), so feel free to clarify anything. |
I don't know if this should just be addressed in a different PR, but it would also be good to re-factor to move away from YAML anchors, we well as separating each platform's CI pipelines into separate files for readability. @jdmacam if you want to leave that for another PR, please create an issue to track the refactoring (along with viewing Ascent/Crusher pipeline status) and we can merge this sooner rather than later. |
@cameronrutherford I resubmit the pipeline and everything looks good to me. Probably our platform was too busy when you launched the pipeline. |
@cameronrutherford I've added the variable to those pipelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and all pipelines pass. I think this can be merged.
You should notice tests passing a little bit faster as we will no longer have to clone the git repo before running tests where unecessary.
Updates the pnnl_cleanup job in .gitlab-ci.yml to: