Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Cuda without raja #579

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Build: Cuda without raja #579

merged 4 commits into from
Dec 23, 2022

Conversation

cnpetra
Copy link
Collaborator

@cnpetra cnpetra commented Dec 19, 2022 •
edited
Loading

CUDA KKT and Matrix classes now use the newly added cuda vector. This removes dependencies of HIOP_USE_CUDA on HIOP_USE_RAJA.

Close #578

@cnpetra cnpetra marked this pull request as draft December 19, 2022 19:19
@cnpetra cnpetra marked this pull request as ready for review December 19, 2022 20:27
cameronrutherford
cameronrutherford approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one stylistic comment about assertions in LinAlg and Optimization code.

Apart from that this looks great!

src/LinAlg/hiopMatrixSparseCsrCuda.cpp Show resolved Hide resolved
src/LinAlg/hiopVectorCuda.cpp Show resolved Hide resolved
src/Optimization/hiopKKTLinSysSparseCondensed.cpp Show resolved Hide resolved
nychiang
nychiang approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@nychiang nychiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems condensed system and normal equation depends on 'CUDA' vector, doesn't it? May be we should add some comments about this in the user guide and option file (hiopOptions.cpp).

@cnpetra
Copy link
Collaborator Author

cnpetra commented Dec 23, 2022

LGTM. It seems condensed system and normal equation depends on 'CUDA' vector, doesn't it? May be we should add some comments about this in the user guide and option file (hiopOptions.cpp).

#575 is supposed to take care of it

@cnpetra cnpetra merged commit 06a7e57 into develop Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronrutherford cameronrutherford cameronrutherford approved these changes

@nychiang nychiang nychiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable test for condensed linear algebra when raja not present
3 participants
@cnpetra @nychiang @cameronrutherford