Use failure not failed in PNNL commit status posting #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incorrect stage name causes the status of a failed pipeline run not to actually post to GitHub.
|
Maybe this is worth testing, but I noticed this false negative when looking at HyKKT pipelines... cc @ryandanehy @pelesh |
|
This is a tiny PR but is ready for merge. Otherwise, there is no way to capture the failures in PNNL CI. |
cnpetra
approved these changes
Apr 11, 2023
|
I guess this is ready to merge? |
|
Yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect stage name causes the status of a failed pipeline run not to actually post to GitHub.