Develop.pcr #613
Merged
Develop.pcr #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnpetra
approved these changes
Apr 10, 2023
| @@ -88,32 +88,45 @@ namespace hiop | |||
| int mpi_test_flag; MPI_Status mpi_status; | |||
| int ierr = MPI_Test(&request_, &mpi_test_flag, &mpi_status); | |||
| assert(MPI_SUCCESS == ierr); | |||
| if (mpi_test_flag) { | |||
| request_ = MPI_REQUEST_NULL; | |||
There was a problem hiding this comment.
good idea to set it to null request and (sanity) check it later...
| @@ -764,7 +788,7 @@ void hiopAlgPrimalDecomposition::set_local_accum(const std::string local_accum) | |||
|
|
|||
| #ifdef HIOP_USE_MPI | |||
| hiopSolveStatus hiopAlgPrimalDecomposition::run() | |||
| { | |||
| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the problem of not completing non-blocking point-to-point communication operations. It is hypothesized that the lack of completing requests causes some communications libraries to run out of resources for large, long-running runs. The modifications in this pull request should ensure that any non-blocking operation that is posted will have a matching call to complete it (MPI_Wait or MPI_Test).
The modifications represented by this pull request are intentionally minimal and do not change the fundamental communication approach or implementation.