Refactor CUSOLVER-LU module and interface #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
added
solver options
|
I changed names for inner IR options to be generic for any IR implementation. IR now print warning if it fails to converge, but it does not stop the execution. |
pelesh
force-pushed
the
cusolver-cleanup-dev
branch
from
d9557c0
to
a223934
Compare
|
I reverted back to flat, user-set tolerance for "inner" iterative refinement. I believe all comments are addressed with this latest commit and the PR is ready for merge. |
kswirydo
approved these changes
Jun 28, 2023
nychiang
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor linear solver interface to what we referred to as CUSOLVER-LU. The solver itself is now implemented as a standalone library and renamed ReSolve as it will now have HIP backend, as well. Its cuSOLVER dependency will be optional going forward.
This PR has been verified using standard HiOp tests, as well as with ACOPF examples in ExaGO using 10k-, 25k- and 80k-bus grid models.
This PR implements changes that are needed before the interface that allows receiving data on host or device can be implemented (and temporary class
hiopLinSolverSymSparseReSolveGPUcan be removed).Also, fixes #629.