Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in copying an empty matrix into a bigger matrix #666

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Fix a bug in copying an empty matrix into a bigger matrix #666

merged 3 commits into from
Oct 13, 2023

Conversation

nychiang
Copy link
Collaborator

@nychiang nychiang commented Oct 10, 2023 •
edited
Loading

There is a bug in RAJA implementation which fails HiOp when we copy an empty matrix into a bigger matrix.

This PR tries to:

  1. modify the corresponding unit test to catch this segmentation failure.
  2. Avoid copying an empty matrix in the RAJA implementation

CLOSE #665

@pelesh @cameronrutherford @abhyshr

@nychiang nychiang self-assigned this Oct 10, 2023
@nychiang nychiang added bug sparse-develop Issues and PRs pertaining to development of branch sparse-develop labels Oct 10, 2023
pelesh
pelesh reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and all tests pass. @abhyshr, please confirm this fixes the issue you have seen with ExaGO.

@cnpetra cnpetra merged commit c6f94d2 into develop Oct 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelesh pelesh pelesh left review comments

@cnpetra cnpetra cnpetra approved these changes

@cameronrutherford cameronrutherford Awaiting requested review from cameronrutherford

Assignees

@nychiang nychiang

Labels
bug sparse-develop Issues and PRs pertaining to development of branch sparse-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when copying empty matrix in sparse GPU mode
3 participants
@nychiang @cnpetra @pelesh