Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue caused by adding cflag NDEBUG #672

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix the issue caused by adding cflag NDEBUG #672

wants to merge 3 commits into from

Conversation

nychiang
Copy link
Collaborator

Issue #667 and #668 are caused by using cflag -Wall -Werror together with -DNDEBUG.
Some variables used only in assert(...) become unused and throw compiling errors.

CLOSE #667
CLOSE #668

@nychiang nychiang requested a review from cnpetra October 30, 2023 03:22
@nychiang nychiang changed the title Hip cpp17 fix Fix the issue caused by adding cflag NDEBUG Oct 30, 2023
@nychiang nychiang mentioned this pull request Oct 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnpetra cnpetra Awaiting requested review from cnpetra

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hiop fails to build on Frontier with Exago build script from KPP2 hiop@develop%clang-rocm unable to build
1 participant
@nychiang