Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake paths be relative to hiop project #684

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

chapman39
Copy link
Collaborator

This PR will allow lido and other projects to utilize hiop as a submodule.

  • Update cmake variables to use switch to using PROJECT_BINARY_DIR and PROJECT_SOURCE_DIR rather than their cmake counterparts. This should not affect regular hiop builds.

@chapman39 chapman39 self-assigned this Mar 13, 2024
@chapman39
Copy link
Collaborator Author

Seems like I'm missing some permissions

https://github.com/LLNL/hiop/actions/runs/8270156566/job/22627066587?pr=684

remote: HTTP Basic: Access denied.
The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password.
See https://gitlab.pnnl.gov/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied

@chapman39 chapman39 changed the title WIP: Update cmake paths be relative to hiop project Update cmake paths be relative to hiop project Mar 14, 2024
Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable changes, although I would recommend spack over submodules where appropriate

@cameronrutherford
Copy link
Collaborator

cameronrutherford commented Mar 15, 2024

Seems like I'm missing some permissions

https://github.com/LLNL/hiop/actions/runs/8270156566/job/22627066587?pr=684

remote: HTTP Basic: Access denied.
The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password.
See https://gitlab.pnnl.gov/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied

PNNL CI error here isn't because of anything you have done. This is fine to merge IMO

@chapman39
Copy link
Collaborator Author

I do not have permission to merge this PR, but it is finished.

@cnpetra cnpetra merged commit ab54728 into develop Mar 20, 2024
5 of 6 checks passed
@chapman39 chapman39 deleted the feature/chapman39/allow_codevelop_lido branch March 25, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants