-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade docker containers #1074
Upgrade docker containers #1074
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1074 +/- ##
===========================================
- Coverage 88.85% 86.91% -1.94%
===========================================
Files 155 159 +4
Lines 12581 15412 +2831
===========================================
+ Hits 11179 13396 +2217
- Misses 1402 2016 +614 ☔ View full report in Codecov by Sentry. |
…LLNL/serac into task/chapman39/update-docker-2024-02-02
…ate-docker-2024-02-02
…ate-docker-2024-02-02
@samuelpmish @white238 @jamiebramwell I'm not sure if anyone's familiar with this error, but I'm having trouble how to approach it
It's failing only gcc13-release. https://dev.azure.com/llnl-serac/serac/_build/results?buildId=10908&view=logs&j=8418a147-cefe-5fbf-eb11-e069d1299bbe&t=02db9b20-7613-5b66-5602-b48459f634fd&l=463 Edit: I figured it out. |
…ate-docker-2024-02-02
…ate-docker-2024-02-02
RUN sudo sed -i "s/ -ffat-lto-objects//g" /usr/bin/mpicc.mpich | ||
RUN sudo sed -i "s/ -ffat-lto-objects//g" /usr/bin/mpifort.mpich | ||
RUN sudo sed -i "s/ -fallow-invalid-boz//g" /usr/bin/mpifort.mpich | ||
RUN sudo sed -i "s/ -fallow-argument-mismatch//g" /usr/bin/mpifort.mpich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth bringing this up to radiuss-docker, if they end up building clang with mpich.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidbeckingsale would you like this to go into the base radiuss image? The mpich wrappers add link time optimization flags which then fails in the non-gcc compilers due to it being very specific.
--project-json=.uberenv_config.json \ | ||
--spec=%clang@10.0.0~strumpack --prefix=/home/serac/serac_tpls -k \ | ||
--spec=%clang@15.0.7 --prefix=/home/serac/serac_tpls -k \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strumpack works on docker containers now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chapman39 ! Did this pass the style check w/o any changes? That would be amazing since it was so version dependent before.
@chapman39 can you fix the following warning:
Line 104 in 7672d33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chapman39 !
Doxyfile.in
to 1.9.1