Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Uberenv with Spack Environments #882

Merged
merged 41 commits into from
Apr 14, 2023

Conversation

chapman39
Copy link
Contributor

@chapman39 chapman39 commented Feb 3, 2023

Using updated Uberenv with Spack Environments

Built TPLs and devtools now include as part of their install location:
'{compiler.name}-{compiler.version}/{name}-{version}-{hash}'

The serac devtools "latest" symlink will now point at the view directory of a build. This should not affect the way you write the prefixes of devtools in spack.yaml.

Also updates Spack

@chapman39 chapman39 added WIP Work in progress build Build system labels Feb 3, 2023
@chapman39 chapman39 self-assigned this Feb 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #882 (29d66ff) into develop (0ff647e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #882   +/-   ##
========================================
  Coverage    94.75%   94.75%           
========================================
  Files          153      153           
  Lines        10786    10786           
========================================
  Hits         10220    10220           
  Misses         566      566           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -116,17 +116,17 @@ Serac.

.. code-block:: bash

$ python3 scripts/uberenv/uberenv.py --prefix=../serac_libs
$ python3 scripts/llnl/build_tpls.py --prefix=../serac_libs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@white238 do you think we should say build_tpls.py in quickstart as opposed to running simply uberenv.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note: i changed prefix to directory in the next commit)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build_tpls.py is for building all the specs on the given platform. That sometimes doesn't make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill change it back then

@chapman39 chapman39 added ready for review Ready for active inspection by reviewers and removed WIP Work in progress labels Mar 30, 2023
@chapman39
Copy link
Contributor Author

chapman39 commented Apr 7, 2023

I'm having this issue where there are empty view and ._view directories in serac/scripts/spack/devtools_configs presumably whenever I build the devtools. I haven't really figured out how or why this happens. Besides this small issue, the devtools are able to be used with views.

[meemee@ruby968:devtools_configs]$ pwd
/usr/workspace/meemee/serac/repo/scripts/spack/devtools_configs
[meemee@ruby968:devtools_configs]$ ls -la
total 32
drwxrws--- 5 meemee meemee 4096 Apr  6 18:37 .
drwxrws--- 5 meemee meemee 4096 Apr  6 09:44 ..
drwxr-sr-x 3 meemee meemee 4096 Apr  6 18:37 ._view
drwxr-sr-x 2 meemee meemee 4096 Apr  5 14:53 blueos_3_ppc64le_ib_p9
-rw-rw---- 1 meemee meemee 8124 Feb 23 17:12 config.yaml
-rw-rw---- 1 meemee meemee   13 Sep 30  2022 mirrors.yaml
drwxr-sr-x 2 meemee meemee 4096 Apr  5 14:53 toss_3_x86_64_ib
lrwxrwxrwx 1 meemee meemee   97 Apr  6 18:37 view -> /usr/WS2/meemee/serac/repo/scripts/spack/devtools_configs/._view/tgu6msvos6b4jlndsmbpdeea5ttnelkf

@chapman39 chapman39 requested a review from white238 April 7, 2023 01:57
chapman39 and others added 3 commits April 11, 2023 16:58
Co-authored-by: Chris White <white238@llnl.gov>
Co-authored-by: Chris White <white238@llnl.gov>
Co-authored-by: Chris White <white238@llnl.gov>
@chapman39 chapman39 requested a review from white238 April 11, 2023 23:59
build_stage::
- $spack/../build_stage

view:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs to be duplicated in the blueos devtool config spack.yaml

Copy link
Member

@white238 white238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for seeing this through!

@jamiebramwell
Copy link
Member

Trying this out on my local machine now...

@samuelpmishLLNL
Copy link
Contributor

for reference, here's the relevant docs built from this branch:
https://serac.readthedocs.io/en/task-chapman39-update_uberenv/sphinx/quickstart.html#quickstart-label

@jamiebramwell
Copy link
Member

Works on my machine with the ubuntu 20 spack.yaml.

Copy link
Member

@jamiebramwell jamiebramwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @chapman39 !

@chapman39 chapman39 merged commit 33881f6 into develop Apr 14, 2023
@chapman39 chapman39 deleted the task/chapman39/update_uberenv branch April 14, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system ready for review Ready for active inspection by reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants