Add Tribol to codevelop build #985
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #985 +/- ##
===========================================
+ Coverage 89.83% 89.86% +0.03%
===========================================
Files 149 149
Lines 12091 12091
===========================================
+ Hits 10862 10866 +4
+ Misses 1229 1225 -4 ☔ View full report in Codecov by Sentry. |
|
Should this go in before or after the other Tribol PR? |
Either should be OK, but I think the other Tribol PR should be higher priority and is in a more ready-to-merge state. |
|
@chapman39 @white238 , could you take a look at this? |
| if(${PROJECT_NAME} STREQUAL "smith") | ||
| include(serac/tribol/cmake/TribolMacros.cmake) | ||
| add_subdirectory(${PROJECT_SOURCE_DIR}/serac/tribol/src ${CMAKE_BINARY_DIR}/tribol) | ||
| tribol_configure_file(${PROJECT_SOURCE_DIR}/serac/tribol/src/tribol/config.hpp.in |
There was a problem hiding this comment.
Why is tribol not configuring this file itself?
There was a problem hiding this comment.
It will when LLNL/Tribol#45 is merged in. Added a note here as a reminder to get rid of this when we update serac's Tribol again.
| $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/tribol/src> | ||
| ) | ||
|
|
||
| target_include_directories(tribol PUBLIC |
There was a problem hiding this comment.
I really wish I could figure out why these includes disappear. Axom does the same thing and I can't for the life of my figure out why.
|
@white238 could you take another look at this? |
This adds Tribol to the serac codevelop build (see #981).