Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$to variable not consistent in createHtmlMessage() and getDefaultMessage() #3

Closed
mihail-finsbury-bg opened this issue Apr 4, 2023 · 1 comment · Fixed by #4
Closed
Assignees
Labels
bug Something isn't working

Comments

@mihail-finsbury-bg
Copy link

mihail-finsbury-bg commented Apr 4, 2023

Hello,

There is an inconsistency between createHtmlMessage and getDefaultMessage

public function createHtmlMessage(string|Address|AddressInterface|array|AddressList|Traversable|null $from,
                                      string|Address|AddressInterface|array|AddressList|Traversable $to,
                                      string $subject,
                                      string|ModelInterface $nameOrModel): Message
protected function getDefaultMessage(string|Address|AddressInterface|array|AddressList|Traversable|null $from,
                                         string $encoding,
                                         string|array $to,
                                         string $subject,
                                         MimeMessage|string $body): Message

if I use the createHtmlMessage() function with an AddressList as $to parameter this function internally calls getDefaultMessage and it passes $to parameter as it is which causes an error since getDefaultMessage $to parameter can only be either string or an array.

Please make sure that same $to parameter types are transferred from createHtmlMessage() to the getDefaultMessage()

Thank you

@visto9259
Copy link
Member

@mihail-finsbury-bg
Thanks for the issue. I will correct it shortly

visto9259 added a commit to visto9259/LmcMail that referenced this issue Apr 5, 2023
@visto9259 visto9259 mentioned this issue Apr 5, 2023
visto9259 added a commit that referenced this issue Apr 5, 2023
@visto9259 visto9259 self-assigned this Apr 5, 2023
@visto9259 visto9259 moved this to In Progress in LmcMail Development Apr 5, 2023
@visto9259 visto9259 moved this from In Progress to Done in LmcMail Development Apr 5, 2023
@visto9259 visto9259 added the bug Something isn't working label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants