Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Extend Role to include Hierarchical role #53

Closed
Tracked by #16
visto9259 opened this issue Jul 5, 2024 · 1 comment
Closed
Tracked by #16

Proposal: Extend Role to include Hierarchical role #53

visto9259 opened this issue Jul 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request v2 To be implemented in version 2

Comments

@visto9259
Copy link
Member

The current implementation of Role only support flat roles.
Hierarchical roles is implemented by HierarchicalRole.
InMemoryRoleProvider and ObjectRepositoryRoleProvider use hierarchical roles.
Laminas' role is a hierarchical role.

Therefore, hierarchical role should be the "default". Flat role is just a hierachical role with no children.

Proposal:

  • Have Role support hierarchical role which makes it more like Laminas'
  • Extend RoleInterface to include hasChildren and getChildren
  • Have HierarchicalRole extend Role and mark it as deprecated
  • Have HierarchicalRoleInterface extend RoleInterface and mark it as deprecated.
@visto9259 visto9259 added enhancement New feature or request v2 To be implemented in version 2 labels Jul 5, 2024
@visto9259 visto9259 changed the title Poposal: Extend Role to include Hierarchical role Proposal: Extend Role to include Hierarchical role Jul 5, 2024
@visto9259 visto9259 self-assigned this Jul 5, 2024
visto9259 added a commit to visto9259/LmcRbac that referenced this issue Jul 8, 2024
Signed-off-by: Eric Richer eric.richer@vistoconsulting.com <eric.richer@vistoconsulting.com>
@visto9259
Copy link
Member Author

Completed

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in LmcRbac Development Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 To be implemented in version 2
Projects
Status: Done
Development

No branches or pull requests

1 participant